Support Python 3 #19
Merged
Support Python 3 #19
+26
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requirements.txt now includes the newer websocket and requests versions for use with the api code.
tedivm
reviewed
Aug 26, 2017
| # If we lose the connection to the remote system close the console. | ||
| if data.startswith('### closed ###'): | ||
| if data.startswith(b'### closed ###'): |
There was a problem hiding this comment.
What's the point of turning these into "bytes" instead of just strings? You do it in some other areas as well.
There was a problem hiding this comment.
data is a byte array, in Python 3. startswith will throw on mismatched types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compatibility with Python 3 to allow it to properly behave as Python 2 does.
Requires completion of Python Screeps PR #22 to function on Python 3.